-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Don't force annotation unpickling when testing for SilentIntoAnnot #23506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I should have seen error in the original commit. |
The windows test was failing, presumably because it used a different file order in the compilation than the main test. I verified that the following order gives a cyclic reference error:
The error under
I thought of creating an issue for this. But then I noted that the project uses a package object inheritance of an inner trait which should be illegal: import scalaql.syntax.ScalaqlSyntax
package object scalaql extends ScalaqlSyntax So I guess we should work on making this illegal, instead of trying to fix the consequences to the typing. The workaround is to not to use an import in |
Fixes the cyclic reference error observed when compiling files using sc annotations_1.scala Query_1.scala ScalaqlSyntax_1.scala package.scala_1.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proved to fix builds in project https://github.com/VirtusLab/community-build3/actions/runs/16278606609/job/45963850140
Don't force completion of annotation unpickling when testing for SilentIntoAnnot
Fixes #23496